Send discovered_nodes in bulk from control connection #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harunzengin
commented
Apr 12, 2023
|
@harunzengin no need for a new Telemetry event. Let't just fire a bunch of |
whatyouhide
reviewed
Apr 13, 2023
lib/xandra/cluster.ex
Outdated
| @@ -627,6 +627,20 @@ defmodule Xandra.Cluster do | |||
| {:noreply, state} | |||
| end | |||
|
|
|||
| def handle_info({:discovered_hosts, hosts}, %__MODULE__{} = state) when is_list(hosts) do | |||
| Logger.debug( | |||
| "Discovered hosts: #{Enum.map(hosts, &Host.format_address/1) |> Enum.join(", ")}" | |||
There was a problem hiding this comment.
Nitpick:
Suggested change
| "Discovered hosts: #{Enum.map(hosts, &Host.format_address/1) |> Enum.join(", ")}" | |
| "Discovered hosts: #{Enum.map_join(hosts, ", ", &Host.format_address/1)}" |
Comment on lines
452
to
453
| discovered_hosts = | ||
| Map.values(discovered_peers) |> Enum.map(fn %{host: %Host{} = host} -> host end) |
There was a problem hiding this comment.
If we don't care about the :status, why don't we store the discovered peers as a list of %Host{} directly
Shouldn't we fire |
|
Sorry yes that's what I meant @harunzengin |
|
@whatyouhide Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new message
{:discovered_hosts, [Host.t()]}. I wasn't so sure about whether we should introduce a new telemetry event for this, like:host_discovered. Not sure how useful it would be to be able to distinguish between a:host_added(from cassandra gossip) and:host_discovered(from peers table).Closes #296