SA1019: firestore.WriteBatch is deprecatedの対応 #158
Merged
+674
−509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Visit the 👀 Preview 👀 for this PR (updated for commit 4ac9f96): |
This comment has been minimized.
This comment has been minimized.
wheatandcat
commented
Jan 3, 2023
| @@ -19,7 +20,8 @@ import ( | |||
| const verifyCustomTokenURL = "https://www.googleapis.com/identitytoolkit/v3/relyingparty/verifyCustomToken?key=%s" | |||
|
|
|||
| type User struct { | |||
| UserToken string `yaml:"userToken"` | |||
| UserToken1 string `yaml:"userToken1"` | |||
There was a problem hiding this comment.
以下のissueの対応の土台でe2eでユーザーを2つ作成できるように修正
wheatandcat
commented
Jan 3, 2023
| @@ -45,10 +49,26 @@ func newGraph() graph.Graph { | |||
| AuthUseCase: &moq_usecase_auth.UseCaseMock{}, | |||
| } | |||
|
|
|||
| credJSON, err := ioutil.ReadFile("../serviceAccount.json") | |||
There was a problem hiding this comment.
testでFirestoreClientを使用するので認証のコードを追加
wheatandcat
commented
Jan 3, 2023
| g.App.InviteRepository.Create(ctx, g.FirestoreClient, batch, i) | ||
|
|
||
| if err := g.App.CommonRepository.Commit(ctx, batch); err != nil { | ||
| batch := g.FirestoreClient.BulkWriter(ctx) |
wheatandcat
commented
Jan 3, 2023
| @@ -7,7 +7,7 @@ import ( | |||
| "os" | |||
|
|
|||
| cloudtasks "cloud.google.com/go/cloudtasks/apiv2" | |||
| taskspb "google.golang.org/genproto/googleapis/cloud/tasks/v2" | |||
Code Metrics Report
Details | | 150 (4f9f956) | 150 (4ac9f96) | +/- |
|---------------------|---------------|---------------|------|
| Coverage | 40.4% | 40.4% | 0.0% |
| Files | 9 | 9 | 0 |
| Lines | 559 | 559 | 0 |
| Covered | 226 | 226 | 0 |
| Code to Test Ratio | 1:0.1 | 1:0.1 | 0.0 |
| Code | 14700 | 14700 | 0 |
| Test | 1390 | 1390 | 0 |
- | Test Execution Time | 30s | 33s | +3s |Code coverage of files in pull request scope (69.3% → 69.3%)
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連 issue
対応内容
開発用メモ
無し