Merge pull request #41 from whereby/geirbakke/noop-keepalive

Adds signal socket noop keepalive
whereby · Nov 28, 2023 · 429067d · 429067d
2 parents 7bab7f2 + 70ab0d2
commit 429067d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@whereby/jslib-media",
   "description": "Media library for Whereby",
-  "version": "1.5.1",
+  "version": "1.5.2",
   "private": false,
   "license": "MIT",
   "homepage": "https://github.com/whereby/jslib-media",

diff --git a/src/utils/ServerSocket.js b/src/utils/ServerSocket.js
@@ -5,6 +5,8 @@ import { PROTOCOL_RESPONSES } from "../model/protocol";
 
 const DEFAULT_SOCKET_PATH = "/protocol/socket.io/v4";
 
+const NOOP_KEEPALIVE_INTERVAL = 2000;
+
 /**
  * Wrapper class that extends the Socket.IO client library.
  */
@@ -42,6 +44,24 @@ export default class ServerSocket {
             const transport = this.getTransport();
             if (transport === "websocket") {
                 this._wasConnectedUsingWebsocket = true;
+
+                // start noop keepalive loop to detect client side disconnects fast
+                if (!this.noopKeepaliveInterval)
+                    this.noopKeepaliveInterval = setInterval(() => {
+                        try {
+                            // send a noop message if it thinks it is connected (might not be)
+                            if (this._socket.connected) {
+                                this._socket.io.engine.sendPacket("noop");
+                            }
+                        } catch (ex) {}
+                    }, NOOP_KEEPALIVE_INTERVAL);
+            }
+        });
+
+        this._socket.on("disconnect", () => {
+            if (this.noopKeepaliveInterval) {
+                clearInterval(this.noopKeepaliveInterval);
+                this.noopKeepaliveInterval = null;
             }
         });
     }