Fix adapter imports for sdk #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandito
force-pushed
the
nandor/cob-454-use-wherebycomcore-instead-of-wherebycombrowser-sdkcore
branch
2 times, most recently
from
fa4fed3
to
d99ea24
Compare
5 tasks
nandito
force-pushed
the
nandor/cob-454-use-wherebycomcore-instead-of-wherebycombrowser-sdkcore
branch
4 times, most recently
from
b0ba44b
to
f09910d
Compare
nandito
changed the title
nandito
force-pushed
the
nandor/cob-454-use-wherebycomcore-instead-of-wherebycombrowser-sdkcore
branch
from
f09910d
to
8d6c0ed
Compare
kevinwhereby
approved these changes
Mar 13, 2024
There's a confusion in ESM and CJS, let's try to fix them by using `default` wrapper removal for `adapter` (as suggested here: reduxjs/redux-toolkit#1960)
nandito
force-pushed
the
nandor/cob-454-use-wherebycomcore-instead-of-wherebycombrowser-sdkcore
branch
from
8d6c0ed
to
bd19195
Compare
nandito
deleted the
nandor/cob-454-use-wherebycomcore-instead-of-wherebycombrowser-sdkcore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a confusion in ESM and CJS, let's try to fix them by using
defaultwrapper removal foradapter(as suggested here: reduxjs/redux-toolkit#1960).📦 Published PR as canary version:
1.9.8--canary.89.8267611592.0✨ Test out this PR locally via:
npm install @whereby/jslib-media@1.9.8--canary.89.8267611592.0 # or yarn add @whereby/jslib-media@1.9.8--canary.89.8267611592.0