fix dodgy use of stub promise in test

wheresrhys · Sep 24, 2018 · 65c97cb · 65c97cb
1 parent 4715e34
commit 65c97cb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/lib/fetch-handler.js b/src/lib/fetch-handler.js
@@ -44,8 +44,7 @@ const resolve = async (response, url, opts) => {
 		if (typeof response === 'function') {
 			response = response(url, opts);
 		} else {
-			// Strange .then is to cope with non ES Promises... god knows why it works
-			response = await response.then(it => it);
+			response = await response;
 		}
 	}
 	return response;

diff --git a/test/specs/custom-implementations.test.js b/test/specs/custom-implementations.test.js
@@ -27,8 +27,10 @@ module.exports = fetchMock => {
 
 			it('should allow non-native Promises as responses', async () => {
 				fm.config.Promise = BluebirdPromise;
-				const stub = sinon.spy(() =>
-					BluebirdPromise.resolve(new fm.config.Response('', { status: 203 }))
+				const stub = sinon.spy(fn =>
+					fn(
+						BluebirdPromise.resolve(new fm.config.Response('', { status: 203 }))
+					)
 				);
 				fm.mock(/.*/, {
 					then: stub