Signal request #479
Merged
Signal request #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto signal-request * 'bugs/abort' of https://github.com/Sayan751/fetch-mock: refactor(all): post review changes fix(abort): no abort if signal was in request
|
Turned out to be simpler than I thought as signal is not carried very deep into the library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #473
As implemented, it will be a breaking change for lots of people's tests because any expectation they've made on
optionswill break if they are also usingRequest.It looks like
new Request()always creates a signal property (in the browser - not an issue in node-fetch). I can't expect users to always have to care about abort signals as an artefact even when they are not deliberately working with aborted fetches.I somehow need to carry the signal in to the library on the options so it can be used successfully to abort, but avoid have default signals getting exposed on the options object when inspecting. Probably the answer is to pass signal around as a separate entity, but this involves a bit of work.