Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test built files #551

Merged
merged 29 commits into from
May 11, 2020
Merged

Test built files #551

merged 29 commits into from
May 11, 2020

Conversation

wheresrhys
Copy link
Owner

@wheresrhys wheresrhys commented May 10, 2020 •
edited
Loading

  • test es5 bundle in node6
  • create install tasks for node-fetch@1 & cross-fetch
  • run in all LTS versions and latest node, using ESM and commonjs
  • test key environments such as jest, create-react-app react-native

@coveralls
Copy link

coveralls commented May 10, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.042% when pulling bb525aa on test-built-files into 4f1ef07 on master.

@wheresrhys
rename pipeline
eea58a2
@wheresrhys
test cjs build
cb55678
@wheresrhys
split out typecheck
b66cc0c
@wheresrhys
fix circle config
d906470
@wheresrhys
env -> container
3ee566d
@wheresrhys
use workspace effectively
432aa78
@wheresrhys
fix attaching workspace
b149107
@wheresrhys
fix path to cjs build
c69d2aa
@wheresrhys
refactored test runner to allow for being run as esm
a0f3f0e
@wheresrhys
streamlined test runner tasks in makefile
448b221
@wheresrhys
started using new task names in circle
4029f2c
@wheresrhys
fix circle validation errors
0414f6e
@wheresrhys
lint
37800fd
@wheresrhys
lint .mjs files
f3581c7
@wheresrhys
fix mistake in server side test refactor
252de86
@wheresrhys
revert attempt to run tests in node6 - too legacy and unsupported
0c1fab9
@wheresrhys
theoretically test .mjs files inthe browser
6fd55da 
but karma test runner does not support the extension - will need to move to a different test harness at some point
@wheresrhys
run tests in more versions of node
007edac
@wheresrhys
get linting to work in node 12
ea937fe
@wheresrhys
fix running karma tasks in node 12.15+
8f01da5 
from that version onwards type: "module" throws an error
@wheresrhys
alias verify to lint
e6d3ec7
@wheresrhys
make sure all tests run over built files
59fbffe
@wheresrhys
why does mocha not exist when using esm?
a965c67
@wheresrhys
add esm hook to mocha
ac4572d
@wheresrhys
trey and fail to fix testing esm build in mocha;
ad99063
@wheresrhys
stop trying to get esm tests to pass for now
a1baad3
@wheresrhys wheresrhys marked this pull request as ready for review May 10, 2020 19:06
@wheresrhys wheresrhys merged commit 1d84221 into master May 11, 2020
@wheresrhys wheresrhys deleted the test-built-files branch May 31, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wheresrhys @coveralls