Use promises instead of done() for async tests #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses Mocha's neat promise support and a bit of promise chaining to generate more meaningful test failures during development while keeping the code clean.
(The alternative would have been to put a
try { ... } catch(e) { done(e); }
around each deferredexpect
block, and that's just plain nasty)I'll happily rebase #83 in this style if this PR is accepted.