Networking: Add UseCase Success/Failure for network calls #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamziJabali
changed the title
seljabali
changed the title
seljabali
reviewed
Jan 10, 2022
shared/src/commonMain/kotlin/co/touchlab/kampkit/metaweather/repo/WeatherUseCase.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 10, 2022
shared/src/commonMain/kotlin/co/touchlab/kampkit/metaweather/repo/WeatherUseCase.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 10, 2022
shared/src/commonMain/kotlin/co/touchlab/kampkit/metaweather/repo/WeatherUseCase.kt
Show resolved
Hide resolved
seljabali
reviewed
Jan 10, 2022
shared/src/commonMain/kotlin/co/touchlab/kampkit/metaweather/repo/HttpStatusCodeState.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 10, 2022
shared/src/commonMain/kotlin/co/touchlab/kampkit/metaweather/ktor/Response.kt
Outdated
Show resolved
Hide resolved
|
Couldn't connect to backend because we're using |
|
|
|
I'm not sure how I feel about the |
seljabali
reviewed
Jan 10, 2022
shared/src/commonMain/kotlin/co/touchlab/kampkit/metaweather/repo/ApiCallResultState.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 10, 2022
app/src/main/java/co/touchlab/kampkit/android/metaweather/States.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 10, 2022
shared/src/commonMain/kotlin/co/touchlab/kampkit/metaweather/ktor/MetaWeatherApiImpl.kt
Show resolved
Hide resolved
seljabali
reviewed
Jan 10, 2022
app/src/main/java/co/touchlab/kampkit/android/metaweather/view/ViewSideEffects.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 10, 2022
shared/src/commonMain/kotlin/co/touchlab/kampkit/metaweather/ktor/MetaWeatherApi.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 11, 2022
app/src/main/java/co/touchlab/kampkit/android/design/DimensionPresets.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 11, 2022
app/src/main/java/co/touchlab/kampkit/android/landingpage/view/MainActivity.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 11, 2022
app/src/main/java/co/touchlab/kampkit/android/landingpage/view/MainActivity.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 11, 2022
app/src/main/java/co/touchlab/kampkit/android/landingpage/view/MainActivity.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 11, 2022
app/src/main/java/co/touchlab/kampkit/android/landingpage/view/screens/WeatherReportView.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 11, 2022
shared/src/commonMain/kotlin/co/touchlab/kampkit/metaweather/repo/WeatherUseCase.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 11, 2022
app/src/main/java/co/touchlab/kampkit/android/design/DimensionPresets.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 11, 2022
app/src/main/java/co/touchlab/kampkit/android/design/DimensionPresets.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 11, 2022
app/src/main/java/co/touchlab/kampkit/android/design/DimensionPresets.kt
Outdated
Show resolved
Hide resolved
seljabali
reviewed
Jan 11, 2022
app/src/main/java/co/touchlab/kampkit/android/design/DimensionPresets.kt
Outdated
Show resolved
Hide resolved
|
May you please move all colors into a |
|
May we please revert iOS changes, and have that be a part of another PR. Thanks! |
Sure, let me know if there are more iOS changes required. |
seljabali
reviewed
Jan 11, 2022
| .padding(start = Spacing.Horizontal.m) | ||
| .fillMaxWidth() | ||
| ) | ||
| Divider(modifier = Modifier.padding(8.dp)) |
There was a problem hiding this comment.
Modifier.padding(Spacing.Surrounding.m)
seljabali
reviewed
Jan 11, 2022
| <systemColor name="systemBackgroundColor"> | ||
| <color white="1" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/> | ||
| </systemColor> | ||
| </resources> | ||
| </document> |
seljabali
reviewed
Jan 11, 2022
| </objects> | ||
| <point key="canvasLocation" x="137.68115942028987" y="79.6875"/> | ||
| </scene> | ||
| </scenes> | ||
| <resources> | ||
| <image name="heart" catalog="system" width="128" height="109"/> | ||
| <systemColor name="systemBackgroundColor"> | ||
| <color white="1" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/> | ||
| </systemColor> | ||
| </resources> | ||
| </document> |
seljabali
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Networking: Add UseCase Success/Failure for network calls
Fix
Used Sealed classes with Generic types for Success and Failure case
Success case
Failure case