Clarify what "complete" configuration block means #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyjeffries
added a commit
that referenced
this pull request
Sep 1, 2015
Clarify what "complete" configuration block means
|
LOL! Thanks @chibicode merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a documentation update suggestion - I might be the only person dumb enough to run into this error, but it might actually be helpful to someone.
Motivation: I ran into the following error when I tried to change the faraday configuration option:
I assumed that calling
faraday_configwould overwrite the default options, so I thought it'd keep default options such asfaraday.headers['Accept'] = "application/json". But it turned out that it replaces the default options. It took me forever to realize this because the error was on this line, which didn't seem to have much to do with the config. I updated the README so that hopefully people won't run into the same issue.