wip: Vm opcodes REVERT (2nd try)

[whilei]

#16 was failing tests, I think because I refactored the EVM.Run iterator wrongly.

---

This change is 

[tzdybal]

Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @whilei)

---

core/execution.go, line 221 at r1 (raw file):

	ret, err = evm.Run(contract, input)
	if err != nil {
		if err != nil {

Wait, what?! ;)

I think you meant if err != vm.ErrExecutionReverted.

---

core/vm/jump_table.go, line 27 at r1 (raw file):

	// returns determines whether the operation sets the return data
	returns bool
	reverts bool // determines whether the operation reverts state (implicitly halts)

Once again, I don't like this approach - we can have just a simple predicate function.

[whilei]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @whilei and @tzdybal)

---

core/execution.go, line 221 at r1 (raw file):

Previously, tzdybal (Tomasz Zdybał) wrote…

Wait, what?! ;)

I think you meant if err != vm.ErrExecutionReverted.

Done.

---

core/vm/jump_table.go, line 27 at r1 (raw file):

Previously, tzdybal (Tomasz Zdybał) wrote…

Once again, I don't like this approach - we can have just a simple predicate function.

Doing.