-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: Vm opcodes REVERT (2nd try) #17
base: vm-opcodes-returns
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @whilei)
core/execution.go, line 221 at r1 (raw file):
ret, err = evm.Run(contract, input) if err != nil { if err != nil {
Wait, what?! ;)
I think you meant if err != vm.ErrExecutionReverted
.
core/vm/jump_table.go, line 27 at r1 (raw file):
// returns determines whether the operation sets the return data returns bool reverts bool // determines whether the operation reverts state (implicitly halts)
Once again, I don't like this approach - we can have just a simple predicate function.
492f904
to
9f48f45
Compare
8931479
to
0731cda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @whilei and @tzdybal)
core/execution.go, line 221 at r1 (raw file):
Previously, tzdybal (Tomasz Zdybał) wrote…
Wait, what?! ;)
I think you meant
if err != vm.ErrExecutionReverted
.
Done.
core/vm/jump_table.go, line 27 at r1 (raw file):
Previously, tzdybal (Tomasz Zdybał) wrote…
Once again, I don't like this approach - we can have just a simple predicate function.
Doing.
#16 was failing tests, I think because I refactored the
EVM.Run
iterator wrongly.This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)