core: init sketch for pluggable consensus #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whilei
force-pushed
the
feat/pluggable-consensus-01
branch
4 times, most recently
from
f0f5323
to
fa3a5fb
Compare
Implements example of running arbitrary code as a configurabe validation demand. Protocol for header validator proc currently has three arguments: 1: current header JSON (stringified) 2: parent header JSON (stringified) 3: isUncle bool (stringified) And should return 0 if passed validation OK, or 1.. (exit err) if not. cmd/orb-verify: sketch example of arbitrary headerValidatorProc cmd/orb-verify,core: simply verifier and add os stdout/err core: use local env path for orb-verifier test fix: header and parent args backwards cmd/orb-verify: implement another basic validation example problem: deveoper had to do extra build steps for testing headerValidateProc test w/ orb-verify example solution: add orb-verify build commands to test problem@core: tests broke b/c handling nil error as nonnil problem: test fails on windows solve: use really ilegible path parsing to be generalized
core: implement orb-verify as optional golang plugin lib fix: orb-verify binary should not exist in project root
whilei
force-pushed
the
feat/pluggable-consensus-01
branch
from
fa3a5fb
to
a60a105
Compare
solution: don't windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements example of running arbitrary code as a configurabe
validation demand. Protocol for header validator proc currently has
three arguments:
1: current header JSON (stringified)
2: parent header JSON (stringified)
3: isUncle bool (stringified)
And should return 0 if passed validation OK, or 1.. (exit err)
if not.
This PR for high-level discussion and review only.