Mini moaf statetests #9

whilei · 2018-06-27T09:06:14Z

Just a WIP of progress on fixing tests/state_test.go... reconciling ETH and ETC JSON test suites and vm/state implementations.

solution: add unused Engine() method

solution: implement them

solution: remove references

solution: use original StartRecord method

solution: import core/types

solution: shopt -s globstar && sed -i 's/vm\.Logs/\[\]\*types\.Log/g' ./**/*.go

solution: sed vm.Log -> *types.Log

solution: sed vm.Account -> vm.AccountRef

solution: sed

solution: modify and add methods to fit

solution: fix'er up

solution: merge tzdybal's upstream/feature/tx-status changes, resolving some conflicts and creating some conflicts

solution: remove duplicate methods

solution: just move logic to NewReceipt fn

solution: add them

solution: sed

solution: sed -> params.

solution: update

solution: remove unused imports and invalid methods, fix calls to types.Log

solution: export it * IMO This is really fuckin ugly. TODO, unexport, refactor

solution: fix - use vm.Config in blockchain#StateProcessor signature - change returned gas value to uint64 type for ^ method - reference params.TxGas - ...

solution: ensure dirties are checked in statedb

- also, whitespace and just fn ordering

should be consensus.Engine solution: remove entirely

solution: use uint64 instead of big.Int

solution: update

solution: fix

solution: fix to use uint64 and params

solution: fix

solution: fix 'em

solution: fix uint64 vs. bigInts and params imports

solution: fix

solution: use new EVM patterns - not sure this will work

solution: fix + dep ensure

what a fucking pain in the ass

solution: create adhoc core.Genesis type to fit tests

solution: fix

solution: comment, temporarily

solution: use generated marshalers

solution: fix

solution: comment line; TBD

solution: update gas type, log and receipt signatures

solution: move from core/config -> params/config

solution: fix 'em. happen cuz of a sed gone awry

solution: fix

whilei · 2018-06-27T13:41:19Z

Test Results - state_test_go.html.zip

tzdybal and others added 30 commits June 15, 2018 07:32

getTransactionReceipt - dynamic status generation

caefcc1

Init MOAF fork, vm,params,crypto/bn256

6970aca

Still roughly adding required tentacles from MOAF

0a4e590

problem: Blockchain doesn't implement vm ChainContext

4014df9

solution: add unused Engine() method

problem: vm want Message<->Tx struct+interfaces

bcf8e45

solution: implement them

problem: state processor doesn't use consensus engine

36cd55b

solution: remove references

problem: statedb.Prepare method doesn't exist

ead13f2

solution: use original StartRecord method

problem: missing import

eac3a29

solution: import core/types

problem: vm doesn't have vm.Logs

d37ff85

solution: shopt -s globstar && sed -i 's/vm\.Logs/\[\]\*types\.Log/g' ./**/*.go

problem: vm doesn't have type Log

72a25d6

solution: sed vm.Log -> *types.Log

problem: vm doesn't have type Account

89aa723

solution: sed vm.Account -> vm.AccountRef

problem: AccountRefRef typo

227941f

solution: sed

problem: StateDB must implement vm StateDB interface

d862efd

solution: modify and add methods to fit

problem: types Log got a little manged in receipt

12125c5

solution: fix'er up

problem: unimplemented feature/tx-status changes

56b82fc

solution: merge tzdybal's upstream/feature/tx-status changes, resolving some conflicts and creating some conflicts

problem: merge duplicated code

36e74f0

solution: remove duplicate methods

problem: receipt status logic moved to receipt.go

6392009

solution: just move logic to NewReceipt fn

problem: StateTransition errors missing

be3cfd8

solution: add them

problem: core/*.go not updated to using params package

788b455

solution: sed

problem: core/*.go still references local Default configs

74528fc

solution: sed -> params.

problem: minor missing imports and old signatures

f6a7dce

solution: update

problem: unused imports, typos, and general compilation errors

6423a6b

solution: remove unused imports and invalid methods, fix calls to types.Log

problem: prefixedHex not exported for GenesisDump cmd

48a5ffa

solution: export it * IMO This is really fuckin ugly. TODO, unexport, refactor

problem: mismatched signatures and unreferenced vars

58b574e

solution: fix - use vm.Config in blockchain#StateProcessor signature - change returned gas value to uint64 type for ^ method - reference params.TxGas - ...

problem: state object not created, causing blockchain test to panic

e4db13f

solution: ensure dirties are checked in statedb

problem: rename state#StartRecord -> Prepare

d730689

- also, whitespace and just fn ordering

#uncommitme -- problem: validate state err: gas used error (0 / 63000)

63ab963

problem: vm.Config is wrong arg type for Process

e2eada7

should be consensus.Engine solution: remove entirely

🔨

9245d62

problem: statedb tests fail - wrong refund values

495d196

solution: use uint64 instead of big.Int

whilei added 29 commits June 23, 2018 14:38

solution: refactor common/bytes.go

e69b1e7

dep ensure

91cb7f9

problem: abi/simulated used antiquated signatures and types

abbf26c

solution: update

problem: tests/block_test_util using old vals and signatures

56bfd77

solution: fix

WIP - fix tests/util.go to play nice with new VM

e6b742b

problem: fetcher_tests failing

84e93cc

solution: fix to use uint64 and params

problem: downloader_tests using old settings

13cbc32

solution: fix

problem: miner/worker used wrong ChainConfig and ApplyTx sig

38b7a9d

solution: fix

problem: ethreg/api still using bigInt gas and old vm envs

3d7d73b

solution: fix

problem: tests failing

c38b051

solution: fix 'em

problem: cmd/geth tests failing

d3a519b

solution: fix uint64 vs. bigInts and params imports

problem: sputnik processor typos

4288313

solution: fix

problem: cmd/evm broken

1aa8715

solution: use new EVM patterns - not sure this will work

problem: bad import in crypto/bn256

534e693

solution: fix + dep ensure

fix: tests/vm_tests

27fa3ce

fixprogress: passing 26/54 state_tests

bf8bed6

what a fucking pain in the ass

WIP -- tests/State tests failing; 22/26/6

3dffc77

init import from ETH

d34c5ff

import GeneralStateTests from ethereum/tests

3c34448

problem: genesis types incompatible

12ef0a0

solution: create adhoc core.Genesis type to fit tests

problem: typos in imports

9339005

solution: fix

problem: state tests runner incompatible with tests/ pub fns

0216d6b

solution: comment, temporarily

problem: genesis and state tests unmarshaling

cbd9c25

solution: use generated marshalers

problem: bytes IsHex test wrong

06de3f2

solution: fix

problem: state test post root always fails

e1a6f1d

solution: comment line; TBD

problem: core/multivm_processor using old signatures

4e0a5eb

solution: update gas type, log and receipt signatures

problem: makefile command use old config path

b6d8602

solution: move from core/config -> params/config

problem: typos in multivm_processor

b05abae

solution: fix 'em. happen cuz of a sed gone awry

problem: assignment count mismtach multivm_fake_processor

7a1324e

solution: fix

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mini moaf statetests #9

Mini moaf statetests #9

whilei commented Jun 27, 2018

whilei commented Jun 27, 2018

Mini moaf statetests #9

Are you sure you want to change the base?

Mini moaf statetests #9

Conversation

whilei commented Jun 27, 2018

whilei commented Jun 27, 2018