Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing AccurateRipResponse tests #333

Closed
JoeLametta opened this issue Nov 14, 2018 · 0 comments
Closed

Failing AccurateRipResponse tests #333

JoeLametta opened this issue Nov 14, 2018 · 0 comments
Assignees
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Needed: tests Tests are required Priority: critical Critical priority Regression Bug that breaks functionality known to work in previous releases
Milestone

Comments

@JoeLametta
Copy link
Collaborator

Travis CI is reporting 3 test failures which don't depend on recent changes introduced by us: we should investigate what's the cause and update the tests to fix the failures.

....WARNING:whipper.common.mbngs:Release with ID '3451f29c-9bb8-4cc5-bfcc-bd50104b94f8' (Jeff Buckley - Everybody Here Wants You) does not have a date
..............ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 1
......FERROR:whipper.common.accurip:could not save entry to /tmp/tmp9x4Fmywhipper_accurip_cache_test/c/1/2/dBAR-002-0000f21c-00027ef8-05021002.bin: "[Errno 13] Permission denied: '/tmp/tmp9x4Fmywhipper_accurip_cache_test/c'"
FERROR:whipper.common.accurip:error retrieving AccurateRip entry: 404 Not Found <Response [404]>
WARNING:whipper.common.accurip:entry not found in AccurateRip database
.F.WARNING:whipper.program.arc:ARC calculation failed: arc return code is non zero: 1
ERROR:whipper.common.accurip:could not calculate AccurateRip v1 checksum for track 1 '/does/not/exist'
WARNING:whipper.program.arc:ARC calculation failed: arc return code is non zero: 1
ERROR:whipper.common.accurip:could not calculate AccurateRip v2 checksum for track 1 '/does/not/exist'
.............................................................................
======================================================================
FAIL: test_AccurateRipResponse_parses_correctly (whipper.test.test_common_accurip.TestAccurateRipResponse)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/whipper-team/whipper/whipper/test/test_common_accurip.py", line 81, in test_AccurateRipResponse_parses_correctly
    self.assertEqual(responses[1].confidences[0], 4)
AssertionError: 5 != 4

======================================================================
FAIL: test_can_return_entry_without_saving (whipper.test.test_common_accurip.TestAccurateRipResponse)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/whipper-team/whipper/whipper/test/test_common_accurip.py", line 54, in test_can_return_entry_without_saving
    self.assertEqual(get_db_entry(self.path), self.entry)
AssertionError: Lists differ: [<whipper.common.accurip._Accu... != [<whipper.common.accurip._Accu...

First differing element 0:
<whipper.common.accurip._AccurateRipResponse object at 0x7f03a7c3da90>
<whipper.common.accurip._AccurateRipResponse object at 0x7f03a7e87f50>

- [<whipper.common.accurip._AccurateRipResponse object at 0x7f03a7c3da90>,
?                                                                 ^^^^^

+ [<whipper.common.accurip._AccurateRipResponse object at 0x7f03a7e87f50>,
?                                                                 ^^^^^

-  <whipper.common.accurip._AccurateRipResponse object at 0x7f03a7c3d250>]
?                                                                 ^^^^^

+  <whipper.common.accurip._AccurateRipResponse object at 0x7f03a7e87e90>]
?                                                                 ^^^^^


======================================================================
FAIL: test_retrieves_and_saves_accuraterip_entry (whipper.test.test_common_accurip.TestAccurateRipResponse)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/whipper-team/whipper/whipper/test/test_common_accurip.py", line 61, in test_retrieves_and_saves_accuraterip_entry
    self.assertEqual(get_db_entry(self.path), self.entry)
AssertionError: Lists differ: [<whipper.common.accurip._Accu... != [<whipper.common.accurip._Accu...

First differing element 0:
<whipper.common.accurip._AccurateRipResponse object at 0x7f03a7c3d250>
<whipper.common.accurip._AccurateRipResponse object at 0x7f03a7e87f50>

- [<whipper.common.accurip._AccurateRipResponse object at 0x7f03a7c3d250>,
?                                                                 ^^^^

+ [<whipper.common.accurip._AccurateRipResponse object at 0x7f03a7e87f50>,
?                                                                 ^^^^

-  <whipper.common.accurip._AccurateRipResponse object at 0x7f03a7c3da90>]
?                                                                 ^^^^

+  <whipper.common.accurip._AccurateRipResponse object at 0x7f03a7e87e90>]
?                                                                 ^^^^


----------------------------------------------------------------------
@JoeLametta JoeLametta added Bug Generic bug: can be used together with more specific labels Accepted Accepted issue on our roadmap Priority: critical Critical priority Needed: replication Bug replication is required Needed: tests Tests are required Needed: patch A pull request is required Regression Bug that breaks functionality known to work in previous releases labels Nov 14, 2018
@JoeLametta JoeLametta added this to the 1.0 milestone Nov 14, 2018
@JoeLametta JoeLametta self-assigned this Nov 16, 2018
@JoeLametta JoeLametta removed Needed: patch A pull request is required Needed: replication Bug replication is required labels Nov 17, 2018
@JoeLametta JoeLametta added Status: in progress Issue/pull request which is currently being worked on and removed Status: in progress Issue/pull request which is currently being worked on labels Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Needed: tests Tests are required Priority: critical Critical priority Regression Bug that breaks functionality known to work in previous releases
Projects
None yet
Development

No branches or pull requests

1 participant