Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Docker instructions in README #452

Closed
trleith opened this issue Jan 17, 2020 · 3 comments
Closed

Improve Docker instructions in README #452

trleith opened this issue Jan 17, 2020 · 3 comments
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Needed: documentation Documentation is required
Milestone
1.0

Comments

@trleith
Copy link

trleith commented Jan 17, 2020

This is a documentation issue.

on the page https://github.com/whipper-team/whipper/blob/develop/README.md

  1. If you have a 32-bit machine, the prebuilt Docker package won't work, you have to build it yourself. This should be mentioned.
  2. There is a missing dot at the end of the line docker build -t whipperteam/whipper . <--- the dot is missing
@github-actions
Copy link

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Support Questions that needs answering with no code changes needed or that only require a one time change labels Jan 17, 2020
@JoeLametta JoeLametta added this to the 1.0 milestone Jan 17, 2020
@JoeLametta JoeLametta added Needed: documentation Documentation is required and removed Support Questions that needs answering with no code changes needed or that only require a one time change labels Jan 17, 2020
@JoeLametta JoeLametta changed the title Build/Install Whipper Improve Docker instructions in README Jan 17, 2020
@JoeLametta
Copy link
Collaborator

I've just fixed the reported issues in commit 553a6de.

Cheers,
Joe

@trleith
Copy link
Author

trleith commented Jan 17, 2020

Perfect -- thanks for all your help on Wednesday -- whipper is running happily on my fifteen year old computer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Needed: documentation Documentation is required
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@JoeLametta @trleith