Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test all four cases of whipper version scheme #456

Merged
merged 1 commit into from Jan 29, 2020
Merged

Test all four cases of whipper version scheme #456

merged 1 commit into from Jan 29, 2020

Conversation

ABCbum
Copy link
Contributor

@ABCbum ABCbum commented Jan 24, 2020 •
edited

Fixes: #427

Solution

Group different version schemes with the actual one generated from the logger
a list to avoid parsing a whole .log file. 4 cases: see https://github.com/pypa/setuptools_scm/#default-versioning-scheme .

@ABCbum ABCbum force-pushed the add-version-test branch 2 times, most recently from c6c2a09 to c5408c2 Compare January 24, 2020 19:19
@JoeLametta
Test all four cases of whipper version schemes
f59caea 
Group different version schemes with the actual one generated from the logger in a list to avoid parsing a whole .log file.
The four possible cases are documented here: https://github.com/pypa/setuptools_scm/#default-versioning-scheme.

Fixes: whipper-team#427.

Signed-off-by: ABCbum <kimlong221002@gmail.com>
@JoeLametta JoeLametta merged commit 56f2b1d into whipper-team:develop Jan 29, 2020
@JoeLametta
Copy link
Collaborator

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeLametta JoeLametta JoeLametta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_result_logger.py: truly test all four cases of whipper version scheme
2 participants
@ABCbum @JoeLametta