Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more compact and easier to decode metadata. #2

Closed
meh opened this issue Jul 5, 2017 · 1 comment
Closed

Use more compact and easier to decode metadata. #2

meh opened this issue Jul 5, 2017 · 1 comment
Labels
enhancement

Comments

@meh
Copy link
Collaborator

meh commented Jul 5, 2017

It might be a good idea to convert the XML files into bincode in the build.rs and then just deserialize it at runtime.

Need to find a way to share the code that actually parses the XML and generates the temporary data structures between the build.rs and the actual code, it may require splitting that code in another crate.
@meh meh added the enhancement label Jul 5, 2017
@meh
Copy link
Collaborator Author

meh commented Jul 7, 2017

This is done, but there are basically no runtime improvements.

@meh meh closed this as completed Jul 7, 2017
rubdos pushed a commit that referenced this issue Mar 29, 2023
@gferon
Setup GitHub Actions CI (#2)
4fbc5c4 
Also:
- reformat all Rust files with rustfmt
- fix Metadata::preferred_international_prefix which was returning the wrong field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@meh