Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ScopedRequest): model scope on request #398

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

ianrobertsFF
Copy link
Contributor

This includes the group key as a property on the ScopedRequest class.

Useful if you want to do anything with the scoped request (specifically in any of the get{specificity}Rules methods) within any fields that may be in the layout. Without this context there is nothing to inform which group you are currently working with (and therefore no way to create and return a FlexibleAttribute)

@voidgraphics
Copy link
Member

Hi, thanks for the PR. Somehow this change breaks the dependent fields test. I can't think of a reason why, but it does. As such, I can't merge it in this state. Do you have any ideas?

@voidgraphics
Copy link
Member

After manual testing, it's a bit of a head scratcher, there are no errors either in the log or in the JS console when I activate a dependent field. There's just nothing happening at all.

@ianrobertsFF
Copy link
Contributor Author

That's very odd, I'll see if I can see why it's occurring, I guess group could be a bit generic, but I don't think it's colliding with anything. I'll make a project to test as I use a fork of flexible content in my projects anyway

@voidgraphics
Copy link
Member

The weirdness keeps increasing. If I use your PR, the test breaks (all the other tests pass though). If I use master, but manually make the same changes you did, all tests pass. Could be something funky with my local setup?

@voidgraphics
Copy link
Member

Got it to work in the end. Had to build the assets and do artisan nova:publish for some reason. Thanks for the PR!

@voidgraphics voidgraphics merged commit 2264062 into whitecube:master Oct 3, 2022
@ianrobertsFF
Copy link
Contributor Author

Aha, sorted at least! Thanks for hopping on it so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants