Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding empty $model propety to the main resource #18

Closed
wants to merge 1 commit into from
Closed

Adding empty $model propety to the main resource #18

wants to merge 1 commit into from

Conversation

shalawani
Copy link
Contributor

According to integrate laravel-auditing we should have $model property defined on the resource

According to integrate [laravel-auditing](https://github.com/owen-it/laravel-auditing) we should have $model property defined on the resource
@toonvandenbos
Copy link
Member

Hi @shalawani,

Why set the model to an empty string? Is there an issue if $model is declared and defaults to null?

Thanks!

@shalawani
Copy link
Contributor Author

Hi @Nyratas
Yes there is an issue when integrating laravel-auditing with your package

@toonvandenbos
Copy link
Member

toonvandenbos commented Feb 21, 2019

@shalawani that's what I understood from your first message. To be more precise, my question would be:

Is there still a problem with the integration of laravel-auditing if you set $model to null, as shown in this example:

public static $model;

Instead of declaring it as an empty string as you did:

public static $model = '';

?

@shalawani
Copy link
Contributor Author

I think the issue was from another thing.

I tested it now without my change and it works ok, Sorry for wasting your time.

@shalawani shalawani closed this Feb 21, 2019
@toonvandenbos
Copy link
Member

I'm glad you found a solution to your problem. Thanks for using NovaPage! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants