-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test regular expression. #42
Conversation
void visit(const PropositionalTrue &) override{}; | ||
void visit(const PropositionalFalse &) override{}; | ||
void visit(const PropositionalAtom &) override{}; | ||
void visit(const PropositionalAnd &) override{}; | ||
void visit(const PropositionalOr &) override{}; | ||
void visit(const PropositionalNot &) override{}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need these and the same for the other concrete visitors because now they are pure virtual methods in the abstract class, for better consistency.
Codecov Report
@@ Coverage Diff @@
## develop #42 +/- ##
===========================================
+ Coverage 33.53% 33.70% +0.17%
===========================================
Files 42 42
Lines 1846 1985 +139
Branches 1165 1208 +43
===========================================
+ Hits 619 669 +50
- Misses 281 336 +55
- Partials 946 980 +34
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!! LGTM, thanks!
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply: