Skip to content
This repository has been archived by the owner on Nov 25, 2020. It is now read-only.

replace getPropertyAccessor with createPropertyAccessor #113

Merged
merged 1 commit into from Jun 30, 2015
Merged

replace getPropertyAccessor with createPropertyAccessor #113

merged 1 commit into from Jun 30, 2015

Conversation

ghost
Copy link

@ghost ghost commented May 25, 2015

getPropertyAccessor was deprecated in Symfony 2.3. This commit solves
a deprecation warning that shows up in Symfony 2.7.

getPropertyAccessor was deprecated in Symfony 2.3. This commit solves
a deprecation warning that shows up in Symfony 2.7.
@sstok
Copy link
Contributor

sstok commented May 25, 2015

Then you should also update the minimum "symfony/property-access" version to 2.3.
"symfony/property-access": "~2.3"

@ghost
Copy link
Author

ghost commented May 25, 2015

ah, i figured that'd already be there. I'll add that

@ghost
Copy link
Author

ghost commented May 25, 2015

submitted as #114, as i think that change stands alone

@tolry
Copy link

tolry commented Jun 14, 2015

👍 since this needs to be done in order to remove the deprecation warnings in 2.7

But shouldn't the version change for symfony/property-access be part of this PR? This version might still (depending on when this or the other PR is merged) result in people upgrading to it while using symfony <= 2.2.

Maybe even bumping the version might be in order?

@ghost
Copy link
Author

ghost commented Jun 14, 2015

@tolry : i changed the dependencies in #114

@MasterB
Copy link

MasterB commented Jun 18, 2015

thanks for working on it!

@Lumbendil
Copy link

👍

richsage added a commit that referenced this pull request Jun 30, 2015
replace getPropertyAccessor with createPropertyAccessor
@richsage richsage merged commit 893d2cc into sampart:master Jun 30, 2015
@tolry
Copy link

tolry commented Jun 30, 2015

Great, thanks for merging this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants