Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upd: Normalize behaviour of getVersionNumber on windows. #82

Merged
merged 1 commit into from Nov 2, 2016

Conversation

cadesalaberry
Copy link
Contributor

The windows version returns 2.2.9.0, whereas the iOS and android version limit it to 2.2.9.

The windows version returns `2.2.9.0`, whereas the iOS and android version limit it to `2.2.9`.
@richsage
Copy link
Contributor

The iOS and Android usage simply return the version string as supplied in the application configuration (eg 1.0, 2.3.5 and so on) - there's no string concatenation that takes place like it does in the Windows version. Therefore I'm unsure as to whether this should be "normalized".

What's the common Windows app convention (not having a Windows device myself) - to include the revision number or not?

@cadesalaberry
Copy link
Contributor Author

From what I found here, it seems like on the windows platform, they are used to "3 dots" version strings. I also went and check my Device Portal which confirmed it.

00 - versionning windows

However by normalizing, I meant keeping it consistent with what the plugin would return on another platform. In my config.xml, I have:

<widget id="com.example"  version="2.2.9" xmlns="http://www.w3.org/ns/widgets">
   ...
</widget>

So I would expect 2.2.9 to be returned.

Personally I would prefer if it returned the cordova version.
In the worst case, we could make another function to return the full version.

What do you think ?

@cadesalaberry
Copy link
Contributor Author

@richsage ?

@cadesalaberry
Copy link
Contributor Author

Hey there, Any updates on when this PR can be merged ?

@richsage
Copy link
Contributor

richsage commented Nov 2, 2016

Sorry - totally forgot :-) Yep, I'm happy with this!

@richsage richsage merged commit 445c23c into sampart:master Nov 2, 2016
@cadesalaberry cadesalaberry deleted the patch-1 branch November 4, 2016 08:45
@cadesalaberry
Copy link
Contributor Author

Could you publish a 0.1.10 😄 on npm please ?

Cheers

@cadesalaberry
Copy link
Contributor Author

@richsage any update on the next npm release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants