Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby master/head - racc is now a bundled gem, not a default gem #927

Closed
MSP-Greg opened this issue Jun 8, 2023 · 6 comments
Closed

Ruby master/head - racc is now a bundled gem, not a default gem #927

MSP-Greg opened this issue Jun 8, 2023 · 6 comments

Comments

@MSP-Greg
Copy link

MSP-Greg commented Jun 8, 2023

When using bundler, breaks running RuboCop with Ruby master/head.

require 'racc/parser'

@iliabylich
Copy link
Collaborator

iliabylich commented Jun 8, 2023

Thanks for reporting. It's an external dependency, if #928 doesn't fix it we'll have to report it in the Racc repository.

@iliabylich
Copy link
Collaborator

I've published parser 3.2.2.2 with the latest Racc, could you test it please?

@MSP-Greg
Copy link
Author

MSP-Greg commented Jun 8, 2023

@iliabylich

Thanks for the quick release. It didn't work. The problem is that Bundler will use 'default' gems, but will not use 'bundled' gems.

So, it's not a ruby/racc issue, as it's due to a change in ruby/ruby. Was debating whether to open an issue there...

JFYI, my normal Ruby for OSS work (Ubuntu & Windows) is master, so I noticed it this morning.

@iliabylich
Copy link
Collaborator

Sorry, I don't get how it affects RuboCop. Parser itself works well with the latest ruby-head, there are no errors on loading racc/parser. If our test suite is able to do require 'parser' then how's it different from RuboCop doing the same?

@MSP-Greg
Copy link
Author

MSP-Greg commented Jun 8, 2023

It's only when used with Bundler. Here racc is a development dependency. I think if it was made a 'normal' dependency things would be fine, but that's kind of a pita for me to test...

With it only as a development dependency, if I run bundle exec rake rubocop, it generates

LoadError: cannot load such file -- racc/parser

@koic
Copy link
Collaborator

koic commented Jun 8, 2023

I opened #929 to resolve this issue and confirm a successful CI at rubocop/rubocop#11942 with Parser 3.2.2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants