Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed experimental feature - Server Signing #289

Merged
merged 3 commits into from Dec 22, 2018
Merged

Conversation

dethos
Copy link
Collaborator

@dethos dethos commented Oct 29, 2018

The ability to received messages signed by the server was added in 2016 and was tagged as an experimental feature.

During the last 2 years it has been available to users, however the implementation remained incomplete (experimental), only worked flawlessly in a few email clients and not gathered much interest by the users and developers.

For these reasons, I don't think we should continue developing this feature. Since it adds more complexity to the codebase, in my opinion we should stop maintaining it as well.

This pull request removes the whole server sign feature.

@dethos dethos requested a review from pjaneiro November 2, 2018 12:54
Copy link
Member

@pjaneiro pjaneiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dethos dethos merged commit 45576de into master Dec 22, 2018
@dethos dethos deleted the remove_server_signed branch December 22, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants