Skip to content

Commit

Permalink
ISSUE-462: Add rexml dependency for Ruby 3.0.0+ (#467)
Browse files Browse the repository at this point in the history
We add rexml as a runtime dependency for environments that make use of
Ruby 3 and up

See: https://stackoverflow.com/a/65480744
Issue: #462

Co-authored-by: Ernesto Tagwerker <ernesto+github@ombulabs.com>
  • Loading branch information
fbuys and etagwerker committed Oct 17, 2023
1 parent 9f7284b commit ebdeba5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -3,6 +3,7 @@
* [CHANGE] Fix test warning related to `cucumber_opts` declaration (by [@faisal][])
* [BUGFIX] Stop using long-deprecated MiniTest module name, removed in 5.19.0 (by [@faisal][])
* [CHANGE] Disable VERBOSE warnings in test stubs (by [@fbuys][])
* [CHANGE] Add rexml dependency for Ruby 3.0.0+ support (by [@fbuys][])
* [BUGFIX] Raise error when the same branches are compared (by [@rishijain][])

# v4.8.1 / 2023-05-17 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.8.0...v4.8.1)
Expand Down Expand Up @@ -434,3 +435,4 @@
[@faisal]: https://github.com/faisal
[@96RadhikaJadhav]: https://github.com/96RadhikaJadhav
[@Fito]: https://github.com/Fito
[@fbuys]: https://github.com/fbuys
1 change: 1 addition & 0 deletions rubycritic.gemspec
Expand Up @@ -36,6 +36,7 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency 'parser', '>= 3.2.2.1'
spec.add_runtime_dependency 'rainbow', '~> 3.1.1'
spec.add_runtime_dependency 'reek', '~> 6.0', '< 7.0'
spec.add_runtime_dependency 'rexml'
spec.add_runtime_dependency 'ruby_parser', '~> 3.20'
spec.add_runtime_dependency 'simplecov', '>= 0.22.0'
spec.add_runtime_dependency 'tty-which', '~> 0.5.0'
Expand Down

0 comments on commit ebdeba5

Please sign in to comment.