Skip to content

Commit

Permalink
CHANGE: clean warning by creating cucumber_opts with %w[] instead of ''
Browse files Browse the repository at this point in the history
- Declare cucumber_opts with a %w[] instead of a string, as the latter produces a warning while testing, and may be unsafe.
  • Loading branch information
faisal committed Sep 13, 2023
1 parent e09bffc commit fa7a478
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# main [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.8.1...main)

* [CHANGE] Fix test warning related to `cucumber_opts` declaration (by [@faisal][])
* [BUGFIX] Stop using long-deprecated MiniTest module name, removed in 5.19.0 (by [@faisal][])

# v4.8.1 / 2023-05-17 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.8.0...v4.8.1)
Expand Down
2 changes: 1 addition & 1 deletion Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Rake::TestTask.new do |task|
end

Cucumber::Rake::Task.new(:features) do |t|
t.cucumber_opts = 'features --format progress --color'
t.cucumber_opts = %w[features --format progress --color]
end

RuboCop::RakeTask.new
Expand Down

0 comments on commit fa7a478

Please sign in to comment.