Drop Ruby 2.7 support, and take advantage of Ruby 3.0 #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisal
changed the title
faisal
changed the title
faisal
force-pushed
the
ruby_3
branch
2 times, most recently
from
43ea5f0
to
c25ad90
Compare
yeah, lets merge #480 first, then rebase this. |
…_parser dependencies Also address Lint/UselessAssignment and Style/MapIntoArray warnings that newer versions of rubocop will complain about on newer versions of Ruby. prep for ruby 3
nunosilva800
approved these changes
Apr 15, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for Ruby 2.7.
spec.required_ruby_versionto 3.0, and bumpsome of the
gemrequirements that were held back by the need forRuby 2.7 compatibility.
TargetRubyVersionto 3.0. Take safe autocorrections.ruby-versionlists in the test matrix.Note: This is one commit on top of the pull request for updating dependencies that still work on Ruby 2.7. I split them this way on the theory that a Rubycritic 4.9.1 could keep Ruby 2.7 support, then a Rubycritic 5.0 could bump the minimum support bar to Ruby 3.0 (which is expected to EOL two days ago). I think it approach gives flexibility while settling on a compatibility policy, but they could also be squashed together.
Check list: