Allow for creation of empty FCS files #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Tristan, Thanks for the PR. Re-reading through the FCS 3.1 spec, I see no language disallowing zero event data sections. Can you add a test for creating and reading an empty FCS file to Thanks, |
|
Hi Scott, I added a test as per your request. Hope that does the trick. |
|
Thanks Tristan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Thank you for providing this lightweight tool. I have some use-cases where I need to perform filtering on an FCS file, which can result in an empty
event_dataarray. Typically, this would raise aValueError. However, by removing a couple of lines, I can still write the file to disk while retaining the metadata. Maybe you could drop this as I haven't noticed any problems with the created files.