Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tokio optional #7

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Make tokio optional #7

merged 2 commits into from
Jan 5, 2024

Conversation

jguhlin
Copy link
Contributor

@jguhlin jguhlin commented Jan 12, 2023

Would you be willing to accept this (or similar) PR? I use bytelines pretty extensively but rarely use tokio, and this cuts down on the dependency tree by hiding it behind a "tokio" feature flag.

No worries either way, cheers.

@nickelc
Copy link

nickelc commented Mar 13, 2023

This can be further optimized by using only the futures-util crate.

use futures_util::stream::{self, Stream};
[dependencies]
futures-util = { default-features = false }

@whitfin
Copy link
Owner

whitfin commented Dec 30, 2023

@jguhlin hi!

So sorry for taking so long to get to this, but happy to merge this in. All looks good, just wanted to double check you're happy with it? Would appreciate if you can add a note to the Tokio part of the README about now needing an option.

Edit: if I don't hear back, I'll circle back soon as get it merged in anyway - I see there's some downstream crates this could be useful for too.

@whitfin whitfin changed the base branch from master to main December 31, 2023 17:46
@whitfin whitfin merged commit 3155521 into whitfin:main Jan 5, 2024
@whitfin
Copy link
Owner

whitfin commented Jan 5, 2024

I'm going to merge this and get it released, but tokio will be enabled by default for the moment. I'm going to follow up (hopefully) soon with modules for the other runtimes rather than just Tokio. At this point I'll major bump, and make std the only default feature: #9

Thank you for your help everyone!

@jguhlin
Copy link
Contributor Author

jguhlin commented Jan 7, 2024

Apologies, I was out of the office until today and taking a break with bg3. I'm happy with it and thanks for pushing the update out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants