Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly terminate distributed caches #321

Merged
merged 2 commits into from
Dec 24, 2023
Merged

Correctly terminate distributed caches #321

merged 2 commits into from
Dec 24, 2023

Conversation

whitfin
Copy link
Owner

@whitfin whitfin commented Dec 24, 2023

Fixes #318.

Something changed in Elixir v1.15 which started showing many errors. Initially I thought it was some bug in the newer version, but it turns out the older versions were just masking an error in tests. This corrects this issue, which was just leaving some unused services around during tests.

@whitfin whitfin merged commit ee5c5ce into main Dec 24, 2023
15 checks passed
@whitfin whitfin deleted the issue-318 branch December 24, 2023 18:22
@kianmeng
Copy link
Contributor

@whitfin Thanks for fixing this. I have tested with latest Elixir (1.16.0) and Erlang/OTP (26.2.1) and all tests passed except for some warnings (I filtered out deprecattion warnings):

$ mix test
    warning: TestHelper.delete_on_exit/1 is undefined (module TestHelper is not available or is yet to be defined)
    │
 49 │     TestHelper.delete_on_exit(name)  
    │                ~      
    │
    └─ test/lib/cachex_case/helper.ex:49:16: CachexCase.Helper.create_cache_cluster/2                      
    └─ test/lib/cachex_case/helper.ex:99:20: CachexCase.Helper.delete_on_exit/1                                               
                                                                                                                                          
    warning: TestHelper.on_exit/2 is undefined (module TestHelper is not available or is yet to be defined)
    │                                                                                                                                     
 52 │     TestHelper.on_exit("stop #{name} children", fn ->~                                               
    │                       
    └─ test/lib/cachex_case/helper.ex:52:16: CachexCase.Helper.create_cache_cluster/2
...

@whitfin
Copy link
Owner Author

whitfin commented Dec 24, 2023

@kianmeng yeah I don't really know what to do about those; the code exists and is valid (it's loaded later, I guess). So I think this is just a false positive, but I'm not sure how to turn it off

@whitfin whitfin modified the milestones: v3.7.0, v4.0.0 Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Elixir 1.15] ** (MatchError) no match of right hand side value: {1, {:error, :no_cache}}
2 participants