Move to using ETS for Cachex states #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 8bc1012 on issue-38 into * on master*. |
|
Changes Unknown when pulling 950e4ee on issue-38 into * on master*. |
|
Changes Unknown when pulling 756ecf6 on issue-38 into * on master*. |
|
Changes Unknown when pulling 57410be on issue-38 into * on master*. |
|
Changes Unknown when pulling 345fe60 on issue-38 into * on master*. |
|
Changes Unknown when pulling f3e5461 on issue-38 into * on master*. |
|
Changes Unknown when pulling a02d1b2 on issue-38 into * on master*. |
|
Note to self: clean up |
|
Changes Unknown when pulling d05889b on issue-38 into * on master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will resolve #38 once merged.
The changes will strip out the internal GenServer worker in favour of everything executing on the calling thread, meaning that the user has better control over concurrency. All states are stored in an ETS table at this point instead. The ETS table is handled by Eternal to make sure it doesn't die.
Both Hooks and Janitors still remain under a Supervisor, which now holds the cache name as the server name. The interface is identical apart from this.
The original intent was to remove the
execute/3action, but it still makes sense to keep (with tweaked documentation) as it avoids hitting the local ETS table N times for N actions.Inspection needs further improvements because it's guaranteed a state, so it hits ETS needlessly. This will be addressed shortly.
gen_delegatedependencyinspectuses the provided stateasyncandtimeoutoptions