Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to simply override replacePreviousChar command without no effects in order for type command to work correctly #383

Closed
wants to merge 2 commits into from

Conversation

whitphx
Copy link
Owner

@whitphx whitphx commented Jul 23, 2020

Related to #115

@whitphx whitphx force-pushed the fix/override-replace-previous-char branch from 20fc858 to 3cd1122 Compare July 23, 2020 15:38
… in order for type command to work correctly
@whitphx whitphx force-pushed the fix/override-replace-previous-char branch from 3cd1122 to 15708d6 Compare July 23, 2020 15:38
@whitphx
Copy link
Owner Author

whitphx commented Oct 17, 2020

This still have a problem of microsoft/vscode#98328 .
However, #478 has resolved the fundamental problem and this fix is now not so important.

@whitphx whitphx closed this Oct 17, 2020
@whitphx whitphx deleted the fix/override-replace-previous-char branch October 17, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant