Skip to content

Commit

Permalink
Update docs
Browse files Browse the repository at this point in the history
  • Loading branch information
whoan committed Oct 22, 2023
1 parent 1188b29 commit 5f9303f
Showing 1 changed file with 10 additions and 14 deletions.
24 changes: 10 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,19 @@ Built-in support for the most known registries:
- Docker Hub
- AWS ECR (private and public)
- GitHub's (old and new registry)
- Google Cloud's
- Google Cloud's (currently not under test)

## :exclamation: New behavior if you force `DOCKER_BUILDKIT=1`
## :star2: Action supercharged

> It only affects multi-stage builds
- Docker updated to 24.0.6
- BuildKit is enabled for faster/parallel builds
- Cache also works with BuildKit enabled except for old GitHub Docker Registry (docker.pkg.github.com). Migrate to ghcr.io or disable BuildKit in the step:

This action relies on old builder output where we could take the hash of each intermediate layer during build and tag it as an image.
When new builder is enabled (`DOCKER_BUILDKIT=1`), this action is not able to push the layers of intermediate stages as it can NOT parse the builder output.
As a workaround, the action now forces `DOCKER_BUILDKIT=0` by default, but if your workflow relies on the new builder, at the temporary price of not using caches for all the stages, you can enable `DOCKER_BUILDKIT` like this in your job step:

- name: Build with DOCKER_BUILDKIT enabled
env:
DOCKER_BUILDKIT: 1
uses: whoan/docker-build-with-cache-action@issue-139
...

For plans to be able to cache all stages with `DOCKER_BUILDKIT=1`, see #138.
- name: Build with DOCKER_BUILDKIT disabled
env:
DOCKER_BUILDKIT: 0
uses: whoan/docker-build-with-cache-action@master
...

## Inputs

Expand Down

0 comments on commit 5f9303f

Please sign in to comment.