Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide buttons that either won't work or won't give user notification on failure #416

Merged
merged 2 commits into from Feb 20, 2019
Merged

Hide buttons that either won't work or won't give user notification on failure #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e32897
Fixed #409: user shouldn't be offered delete button with insufficient…
bodom0015 Feb 20, 2019
85ecc6a
Fixed #415: hide 'Move To' / 'Copy to Home' on Tale Workspaces UI
bodom0015 Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions app/components/ui/files/directory-browser/template.hbs
View file
Open in desktop
Expand Up @@ -86,11 +86,11 @@
<i class="dropdown icon"></i>
<div class="menu">
{{#if (and (eq currentNav.command 'workspace') (lt model.tale._accessLevel 1))}}
<a class="item" {{action "copyToHome" item}}><i class="clone icon"></i> Copy to Home</a>
{{!-- <a class="item" {{action "copyToHome" item}}><i class="clone icon"></i> Copy to Home</a> --}}
<a class="item" href="{{apiUrl}}/item/{{item.id}}/download?contentDisposition=attachment"><i
class="download icon"></i> Download</a>
{{else}}
<a class="item" {{action "move" item}}><i class="folder icon"></i> Move To...</a>
{{!-- <a class="item" {{action "move" item}}><i class="folder icon"></i> Move To...</a> --}}
{{#if (eq currentNav.command 'user_data')}}
<a class="item" href="{{apiUrl}}/folder/{{item.id}}/download?contentDisposition=attachment"><i
class="download icon"></i> Download</a>
Expand All @@ -99,7 +99,7 @@
Rename...</a>
{{!-- <a class="item" {{action "share" item}}><i class="share icon"></i> Share</a>--}}
{{#if (and notInManagePage (eq currentNav.command 'workspace'))}}
<a class="item" {{action "copyToHome" item}}><i class="clone icon"></i> Copy to Home</a>
{{!-- <a class="item" {{action "copyToHome" item}}><i class="clone icon"></i> Copy to Home</a> --}}
{{else}}
<a class="item" {{action "copy" item}}><i class="clone icon"></i> Copy</a>
<a class="item" {{action "remove" item}}><i class="trash icon"></i> Remove</a>
Expand Down Expand Up @@ -140,19 +140,19 @@
<i class="dropdown icon"></i>
<div class="menu">
{{#if (and (eq currentNav.command 'workspace') (lt model.tale._accessLevel 1))}}
<a class="item" {{action "copyToHome" item}}><i class="clone icon"></i> Copy to Home</a>
{{!-- <a class="item" {{action "copyToHome" item}}><i class="clone icon"></i> Copy to Home</a> --}}
<a class="item" href="{{apiUrl}}/item/{{item.id}}/download?contentDisposition=attachment"><i
class="download icon"></i> Download</a>
{{else if (eq currentNav.command 'user_data')}}
<a class="item" href="{{apiUrl}}/item/{{item.id}}/download?contentDisposition=attachment"><i
class="download icon"></i> Download</a>
{{else}}
<a class="item" {{action "move" item}}><i class="folder icon"></i> Move To...</a>
{{!-- <a class="item" {{action "move" item}}><i class="folder icon"></i> Move To...</a> --}}
<a class="item" {{action "rename" item}}><i class="write square icon"></i>
Rename...</a>
{{!-- <a class="item" {{action "share" item}}><i class="share icon"></i> Share</a> --}}
{{#if (and notInManagePage (eq currentNav.command 'workspace'))}}
<a class="item" {{action "copyToHome" item}}><i class="clone icon"></i> Copy to Home</a>
{{!-- <a class="item" {{action "copyToHome" item}}><i class="clone icon"></i> Copy to Home</a> --}}
{{else}}
<a class="item" {{action "copy" item}}><i class="clone icon"></i> Copy</a>
{{/if}}
Expand Down
4 changes: 2 additions & 2 deletions app/components/ui/tale-browser/template.hbs
View file
Open in desktop
Expand Up @@ -212,7 +212,7 @@
{{#if showSelect}}
<div class="ui inverted button" {{action 'select' model}}>Select</div>
{{/if}}
{{#if showDelete}}
{{#if (and showDelete (gt model._accessLevel 0))}}
<a class="ui tiny bottom right attached label" {{action 'attemptDeletion' model}}>
<i class="red remove icon"></i>
</a>
Expand Down Expand Up @@ -308,7 +308,7 @@
{{#if showSelect}}
<div class="ui inverted button" {{action 'select' model}}>Select</div>
{{/if}}
{{#if showDelete}}
{{#if (and showDelete (gt model._accessLevel 0))}}
<a class="ui tiny bottom right attached label" {{action 'attemptDeletion' model}}>
<i class="red remove icon"></i>
</a>
Expand Down