Interpret resource_server as absolute URL #582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The "User Settings" view offers users a way to connect external API tokens to their account for consumption and integration within WholeTale. After authorizing a provider with a particular resource_server value, the UI is supposed to offer a link to that resource_server.
Unfortunately, since the resource_server values received from Girder do not include a protocol, the browser interprets them as a relative path, and appends them to the end of the dashboard URL.
Fixes #581
Approach
Prepend link with
//
to force browser to interpretresource_server
as an absolute URL.Note that we use
//
to avoid potential Mixed-Content errors between HTTPS and HTTP.See https://superuser.com/questions/341301/why-does-instead-of-http-or-https-before-the-actual-link-work
How to Test
resource_server
https://demo.dataverse.org
orhttps://sandbox.zenodo.org