Fixed hard-coded dashboard.local link in provider redirect #589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A hard-coded value for
https://dashboard.local.wholetale.org/settings
was left in the controller for the User Settings view. This obviously will not work in production.Approach
Replace the hard-coded hostname with
config.wholeTaleHost
instead. This value is populated from an environment variable usingsed
when the Ember dashboard is built.How to Test