Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hard-coded dashboard.local link in provider redirect #589

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

bodom0015
Copy link
Member

@bodom0015 bodom0015 commented Feb 3, 2020

Problem

A hard-coded value for https://dashboard.local.wholetale.org/settings was left in the controller for the User Settings view. This obviously will not work in production.

Approach

Replace the hard-coded hostname with config.wholeTaleHost instead. This value is populated from an environment variable using sed when the Ember dashboard is built.

How to Test

  1. Checkout and run this branch locally, rebuild the dashboard
  2. Login to the WholeTale Dashboard
  3. Navigate to the "User Settings" view
  4. Connect an OAuth or DataONE provider
    • After authenticating/authorizing, you should be redirected back to the dashboard

@Xarthisius Xarthisius merged commit 7f98391 into master Feb 12, 2020
@Xarthisius Xarthisius deleted the fix-hardcoded-dashboard-redirect-link branch February 12, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants