Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for authentication and authorization of user accessing instances #44

Merged
merged 7 commits into from Mar 17, 2021

Conversation

craig-willis
Copy link
Contributor

@craig-willis craig-willis commented Mar 5, 2021

Problem/Approach:
See whole-tale/whole-tale#94

Prerequisites:

Test case:

  • Go to https://dashboard.local.wholetale.org
  • Create a tale and start the instance
  • Confirm that the instance can be accessed via iframe and pop-out tab
  • Open the pop-out tab URL in a private/incognito session
  • Confirm that you are redirected through the oauth flow and can access the instance
  • Open the pop-out tab URL in a new private/incognito session for another user
  • Confirm that you get a 403 error (Access denied for instance)

@craig-willis craig-willis changed the title [WIP] Add support for authentication and authorization of user accessing instances Add support for authentication and authorization of user accessing instances Mar 16, 2021


girder:
image: wholetale/girder:latest
image: wholetale/girder:cookie
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's no longer necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants