Use girder jobs for spawning Instances #100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial refactoring ofPOST/DELETE /instance
.POST
endpoint now returns Job object that can be used to track Instance status. Please note that creating an instance is a two step task: volume creation and container creation. Separate jobs are being created for each task. Only the latter is returned by callingPOST /instance
but the former can be accessed viaparent
keyword.After some thought, I kept the original behavior.
POST /instance
still returns instance. There's a new state though:Instance.LAUNCHING
(see server/constants.py for full enum). The actual spawning is done via girder jobs now and they can provide additional status if necessary (when we have interface for that).Note: It requires corresponding branch on gwvolman (
issue_95
)PLEASE DO NOT MERGE UNTIL [WIP] is removed from the title of this PR