Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap errors in lookups with RestException. Fixes #189 #190

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Xarthisius
Copy link
Collaborator

Girder throws nice errors now. They're not parsed and showed to the user in the dashboard, but 500s weren't either.

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #190 into master will increase coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   85.21%   85.58%   +0.37%     
==========================================
  Files          34       34              
  Lines        2036     2047      +11     
==========================================
+ Hits         1735     1752      +17     
+ Misses        301      295       -6
Impacted Files Coverage Δ
server/rest/repository.py 100% <100%> (ø) ⬆️
server/lib/http_provider.py 84% <0%> (+2%) ⬆️
server/lib/resolvers.py 96.87% <0%> (+7.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26cad07...d19b40d. Read the comment docs.

Copy link

@craig-willis craig-willis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed via following test case:

  • Register "doi:123/213" or "http://nonexisting.com"
  • Note no traceback in Girder logs
  • Note 400 error with response body containing error message in console

Now we just need Dashboard to display the error...

@Xarthisius Xarthisius merged commit 920f50d into master Dec 6, 2018
@Xarthisius Xarthisius deleted the issue_189 branch December 17, 2018 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants