Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set identifier on the root folder of imported Globus dataset. Fixes #261 #265

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Xarthisius
Copy link
Collaborator

How to test?

  1. Import Globus dataset (e.g. doi:10.18126/M2301J)
  2. Using Girder UI, navigate to /collection/WholeTale Catalog/WholeTale Catalog/Twin-mediated Crystal Growth: an Enigma Resolved and confirm that meta.identifier is present and equal to doi:10.18126/M2301J

Note: Depends on #263

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #265 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   85.55%   85.55%           
=======================================
  Files          38       38           
  Lines        2181     2181           
=======================================
  Hits         1866     1866           
  Misses        315      315
Impacted Files Coverage Δ
server/lib/globus/globus_provider.py 30.84% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59f534...08dc895. Read the comment docs.

@craig-willis craig-willis merged commit dff1b4a into master Mar 14, 2019
@craig-willis craig-willis deleted the 261_globus_identifier branch March 14, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants