Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publishInfo as array #274

Merged
merged 5 commits into from
Mar 25, 2019
Merged

Add publishInfo as array #274

merged 5 commits into from
Mar 25, 2019

Conversation

craig-willis
Copy link

@craig-willis craig-willis commented Mar 20, 2019

The current publishing implementation stores a single PID (DOI) on the Tale object, but allows the user to publish multiple times, losing track of previously published versions. Supporting re-publishing of a Tale seems like a desirable feature, so this PR updates the Tale model and schema to support an array of objects representing published Tale packages. I also changed the job creation to match the other gwvolman tasks (i.e., use delay())

To test:

  • Checkout dashboard dataone_publishing (optional)
  • Checkout gwvolman dataone_publishing (required)
  • Publish a Tale
  • Inspect the Tale object, note a single entry in publishInfo
  • Publish Tale again
  • Inspect the Tale object, note two entries with latest entry at the end

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #274 into master will increase coverage by 0.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #274     +/-   ##
=========================================
+ Coverage   86.63%   87.14%   +0.5%     
=========================================
  Files          40       40             
  Lines        2372     2364      -8     
=========================================
+ Hits         2055     2060      +5     
+ Misses        317      304     -13
Impacted Files Coverage Δ
server/rest/tale.py 97.71% <ø> (ø) ⬆️
server/schema/misc.py 100% <100%> (ø) ⬆️
server/models/tale.py 95.49% <100%> (+3.82%) ⬆️
server/schema/tale.py 100% <100%> (ø) ⬆️
server/rest/publish.py 100% <100%> (+40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 562b36e...cd9f4d8. Read the comment docs.

@craig-willis craig-willis force-pushed the publish-refactor branch 4 times, most recently from 187c7c7 to 5412983 Compare March 24, 2019 09:33
@craig-willis craig-willis changed the title [WIP] Add publishInfo as array Add publishInfo as array Mar 24, 2019
@craig-willis craig-willis changed the base branch from bagit_export to master March 25, 2019 17:39
@craig-willis craig-willis merged commit 59559c2 into master Mar 25, 2019
@Xarthisius Xarthisius deleted the publish-refactor branch March 26, 2019 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants