Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease notification expiration time #457

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Decrease notification expiration time #457

merged 1 commit into from
Mar 30, 2021

Conversation

craig-willis
Copy link

@craig-willis craig-willis commented Mar 24, 2021

Reduces event notification expiration time for events that do not require user acknowledgment to 5s. This should resolve the problem identified in whole-tale/ngx-dashboard#139 (comment).

To test:

  • As user 1, create and share tale with user 2 with both users actively logged in
  • User 1 and user 2 select metadata page in edit mode
  • User 1 edits tale metadata and saves, user 2 confirms sync modal appears and selects either yes or no
  • Wait 30s
  • Sync modal should not reappear

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #457 (9e8250d) into master (fc0f96b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files          52       52           
  Lines        3929     3929           
=======================================
  Hits         3615     3615           
  Misses        314      314           
Impacted Files Coverage Δ
server/utils.py 76.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc0f96b...9e8250d. Read the comment docs.

@Xarthisius Xarthisius merged commit ccfe906 into master Mar 30, 2021
@Xarthisius Xarthisius deleted the expire-fix branch March 30, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants