Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use build_context when building image for recorded run #188

Merged
merged 1 commit into from Dec 20, 2022

Conversation

craig-willis
Copy link
Collaborator

Fixes whole-tale/whole-tale#126

Test case:

  • Assumes image has never been built
  • Create tale from https://github.com/whole-tale/rrun-test
  • Start recorded run without first building image via Run Tale or Build Image
  • Confirm that image is built, pushed, and run succeeds.

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 72.00% // Head: 71.74% // Decreases project coverage by -0.25% ⚠️

Coverage data is based on head (74dad81) compared to base (c516e49).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   72.00%   71.74%   -0.26%     
==========================================
  Files          11       11              
  Lines        1536     1529       -7     
==========================================
- Hits         1106     1097       -9     
- Misses        430      432       +2     
Impacted Files Coverage Δ
gwvolman/tasks.py 55.81% <0.00%> (-1.16%) ⬇️
gwvolman/build_utils.py 91.66% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Xarthisius Xarthisius merged commit 82c701a into master Dec 20, 2022
@Xarthisius Xarthisius deleted the rrun-fix-build branch December 20, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recorded run fails if image hasn't been built
2 participants