Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zenodo] use new version for subsequent Tale publications #98

Merged
merged 4 commits into from Dec 18, 2019

Conversation

Xarthisius
Copy link
Contributor

Create a new version of a Zenodo deposition for a subsequent Tale publications.

How to test

  1. Create and publish a Tale to sandbox.zenodo.org
  2. Change something (files or metadata) and publish again
  3. Confirm that new version of existing deposition was created.

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #98 into master will increase coverage by 1.58%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #98      +/-   ##
=========================================
+ Coverage   60.01%   61.6%   +1.58%     
=========================================
  Files           9       9              
  Lines        1038    1099      +61     
=========================================
+ Hits          623     677      +54     
- Misses        415     422       +7
Impacted Files Coverage Δ
gwvolman/lib/publish_provider.py 91.89% <100%> (+6.17%) ⬆️
gwvolman/constants.py 100% <100%> (ø) ⬆️
gwvolman/lib/zenodo.py 91.17% <71.15%> (-8.03%) ⬇️
gwvolman/utils.py 38.92% <0%> (+4.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0f1d3...a5946d5. Read the comment docs.

Copy link
Member

@ThomasThelen ThomasThelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xarthisius Xarthisius force-pushed the zenodo_version_updates branch 2 times, most recently from ba19997 to 7f727c4 Compare December 12, 2019 18:13
Copy link
Collaborator

@craig-willis craig-willis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@Xarthisius Xarthisius merged commit 2bf57ac into master Dec 18, 2019
@Xarthisius Xarthisius deleted the zenodo_version_updates branch December 18, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants