New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use varying access level on version/runs methods and add tests #13
Conversation
204e3f0
to
24c8e55
Compare
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=========================================
Coverage ? 73.00%
=========================================
Files ? 6
Lines ? 515
Branches ? 0
=========================================
Hits ? 376
Misses ? 139
Partials ? 0 Continue to review full report at Codecov.
|
Unrelated to this PR, but while testing it I ran into the following error:
How it happened:
|
Looking at this method it seems it was meant to be recursive, so |
Hmm, looks like I've never tested with directories in the workspace. Yes, it should be a recursive call. |
This PR adds and enables tests along with other project maintenance related boilerplate. I sneaked in one minor change related to how ACLs are handled. Before most of the models were forcefully loaded and a single routine
_checkAccess
was called to see if a user has write access to it. Instead of doing that we now load individual objects with proper and varied access level, which is a first step towards integration with our Tale sharing functionality.How to test?
There's not much to test here really. Optionally follow testing steps from whole-tale/ngx-dashboard#55 and see it still works