Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .epub and .mobi to blacklist #16

Closed
GhostLyrics opened this issue Aug 22, 2012 · 5 comments
Closed

Add .epub and .mobi to blacklist #16

GhostLyrics opened this issue Aug 22, 2012 · 5 comments

Comments

@GhostLyrics
Copy link

The popular ebook formats .epub and .mobi should be added to the blacklist.

@tzarskyz
Copy link

I think the blacklist should be left as is. It is very easy to add your own file types. If everyone's preferences were added to the default build not many files would be getting shown other than plain text. I vote for leaving it as is... no need to muck it up when it's a drop of the .plist on textedit type fix.

@GhostLyrics
Copy link
Author

QLStephen is a QuickLook plugin that lets you view plain text files without a file extension.

I think it's not QLStephen's job to preview binary files, is it? Of course I fixed it myself on my computer. Adding those known types to the blacklist was rather a suggestion in order to make it work better out-of-the-box, since you won't be seeing usable data when previewing .epub and .mobi.

@whomwah whomwah closed this as completed Aug 22, 2012
@tzarskyz
Copy link

True, however I think users should discover for themselves if they actually want a different quicklook plugin to view mobi and epub files, which do exist.

Not trying to argue, my only thought was that there are a ton of files that don't give any good detail via quicklook and to put them all in the blacklist by default would be extra work for the developers when it is so easy for us end users to add our own. If you want the mobi/epub quicklook files let me know.

@whomwah
Copy link
Owner

whomwah commented Aug 22, 2012

I meant to say thanks for your suggestion. I wasn't expecting such a quick reply. Here's what I had written

but with a quick bit of searching it looks like there is a [epub QuickLook plugin](https://github.com/jaketmp/ePub quicklook). I'd like to keep the lists as there are for the time being. I don't want to get into the same situation as Homebrew, where most of the time is spent adding and removing strings from a text file based on different peoples user needs.

I take your point though, but right now the lists will be staying as they are.

@tzarskyz
Copy link

think you mixed me up with the original poster. I was advocating leaving the list as-is. Anyhow, thank you for sharing your work and implementing the additions of others. Great QLPlugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants