Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x and y in example code? #11

Closed
vdh opened this issue Nov 24, 2011 · 3 comments
Closed

x and y in example code? #11

vdh opened this issue Nov 24, 2011 · 3 comments

Comments

@vdh
Copy link

vdh commented Nov 24, 2011

Correct me if I'm wrong, but don't you have the x and y variables named the wrong way around in that example code?

The method is is_dark( row, col ), so it really should be a y loop containing an x loop, with @qr.dark?(y,x) instead.

@pisi
Copy link

pisi commented Apr 11, 2012

It is exactly so. I've been questioning myself why my QR codes can not be read by any device and you solved the mystery for me :) Flipping the x,y from example and using .dark?(y,x) instead did indeed make my QRs readable. Thank you @vdh! Glad I found this issue...

@mneumegen
Copy link

I had the same issue...fixed by switching x & y

@bjornblomqvist
Copy link
Contributor

I have changed the example so this is no longer a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants