Add support for named colors in svg export #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whomwah
requested changes
Feb 5, 2022
There was a problem hiding this comment.
Great spot and thanks for the PR Matthew. Could you add your change/fix to the CHANGELOG and I'll get this merged. Some like:
## [Unreleased]
- Added in a handler for when color arguments are passed in as symbols e.g `color: :yellow`. This also allows for the use of the `:currentColor` keyword.
|
@whomwah great - CHANGELOG is all sorted |
whomwah
approved these changes
Feb 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation stated I could use named colors such as :black or :white but digging into the code I found that all color arguments were being prefixed with a #.
I have gone ahead and added in a handler for when color arguments are passed in as symbols. This also allows for the use of the currentColor keyword.