Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code optimization: 30% speedup #6

Merged
merged 20 commits into from Aug 13, 2011
Merged

Code optimization: 30% speedup #6

merged 20 commits into from Aug 13, 2011

Commits on Aug 13, 2011

  1. Packaging files should be ignored by git

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    a5045f4 View commit details
    Browse the repository at this point in the history

  2. The input string is required parameter

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    85679c2 View commit details
    Browse the repository at this point in the history

  3. Use the correction levels in QRERRORCORRECTLEVEL

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    6e3da6d View commit details
    Browse the repository at this point in the history

  4. Better error reporting

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    cc08a17 View commit details
    Browse the repository at this point in the history

  5. Make sure level is a Symbol

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    1216a92 View commit details
    Browse the repository at this point in the history

  6. Move size to the options extraction section

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    0fa9eab View commit details
    Browse the repository at this point in the history

  7. Separate function for counting max data bits

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    65cebad View commit details
    Browse the repository at this point in the history

  8. Use faster Ruby native counters instead of ranges

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    fad9406 View commit details
    Browse the repository at this point in the history

  9. Do not sum only to subtract

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    a19cea7 View commit details
    Browse the repository at this point in the history

  10. Use each dcdata and ecdata array entry only once

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    2d012c8 View commit details
    Browse the repository at this point in the history

  11. Use pre-made Procs instead of long case/when construct 

    Code such as

	case mask_pattern
	when QRMASKPATTERN[:pattern000]
		(i + j) % 2 == 0
	when QRMASKPATTERN[:pattern001]
		i % 2 == 0
	when QRMASKPATTERN[:pattern010]
		j % 3 == 0

is very slow because it requires an `Hash#[]` lookup and a `Kernel#===`
call for every branch of the `case` construct, 3.5 * 2 function calls on
average.

We exploit the fact that `mask_pattern` is a Fixnum and pre-populate an
array of possible computations. This takes exactly one `Array#[]`
lookup and `Proc#call` execution per mask pattern.
    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    293580b View commit details
    Browse the repository at this point in the history

  12. Use QRCode#modules directly instead of is_dark

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    5eabc76 View commit details
    Browse the repository at this point in the history

  13. Simpler code for counting dark points

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    9b7fa53 View commit details
    Browse the repository at this point in the history

  14. Fixed calculation of ratio of darkness

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    84ff757 View commit details
    Browse the repository at this point in the history

  15. Use DEMERIT_POINTS_* instead of magic numbers

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    ab7e5dc View commit details
    Browse the repository at this point in the history

  16. Reuse row while scanning for row patterns

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    1c42501 View commit details
    Browse the repository at this point in the history

  17. Use count += 1 instead of count = count + 1

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    06ccf4a View commit details
    Browse the repository at this point in the history

  18. Decouple QRUtil.get_lost_point from QRCode

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    37b014b View commit details
    Browse the repository at this point in the history

  19. Simplified code for QRUtil.get_length_in_bits

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    f56c29a View commit details
    Browse the repository at this point in the history

  20. Split QRUtil.get_lost_points in four sub functions

    @gioele
    gioele committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    52c9caf View commit details
    Browse the repository at this point in the history