Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wof:population property, round one - Canada #754

Merged
merged 0 commits into from
Apr 28, 2017

Conversation

stepps00
Copy link
Contributor

This PR includes population work for all admin records in Canada, as a first pass to close #240.

Records include the following:

  • If the record has no existing population property, the record was given a default wof:population_rank property with a value of 0.
  • If the record has an existing population property, the record was given:
    • A new src:population property that lists the source of the population figure.
    • A new wof:population property with an integer value equal to the existing population value in the record (priority of existing propertiyes in Expose wof:population property #240).
    • A new wof:population_rank property with an integer value, based on the wof:population figure.

Script used to complete this work: https://github.com/mapzen/whosonfirst-toolbox/blob/master/scripts/issue-240-wof_population.py

Follow-up PR(s) will include this work for all admin records in whosonfirst-data.

@nvkelso
Copy link
Contributor

nvkelso commented Apr 27, 2017

I spot checked a bunch of these, including Vancouver and LGTM.

Properties only, no PIP'ing. Over to @thisisaaronland.

@nvkelso nvkelso assigned thisisaaronland and unassigned stepps00 Apr 27, 2017
@thisisaaronland thisisaaronland merged this pull request into master Apr 28, 2017
@nvkelso nvkelso removed the review-me label Apr 28, 2017
@stepps00 stepps00 deleted the stepps00/population branch May 1, 2017 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose wof:population property
3 participants